search

ZORALab / Hestia

One Peaceful Frontend+Backend Software Library Suite.
https://hestia.zoralab.com
Other
19 stars 1 forks source link

Port PWA Webmanifest File Rendering to Render Stage #34

Closed hollowaykeanho closed 1 year ago

hollowaykeanho commented 1 year ago

Description

Please provide a short description of what feature you're looking forward to
enhance below. Please include the story behind your idea as well to give a
better visualization of your idea.

Appearently, the PWA Icons slows down was mainly due to repeated render across EACH page. Let's switch it to root page only mode like how it was done in Issue #29 .

Expected Behavior

Please specify the expected behavior of your requested enhancement. Some great
and helpful pointers are your expected interface (e.g. command patterns,
simple sketches of the user interface, etc).

PWA Webmanifest is only rendered once.

Current Behavior

Please specify the current behavior (e.g. workaround, blockage, etc).

PWA Webmanifest is repatedly rendered across all pages in the repository.

Attachment

Please drag and drop the necessary data files (e.g. screenshot, logs, etc)
below.
hollowaykeanho commented 1 year ago

Done in 95d9d8569835efd991dd0044a4ced446546fdef7

hollowaykeanho commented 1 year ago

Released in https://github.com/ZORALab/Hestia/releases/tag/v1.0.0