search

ZORALab / Hestia

One Peaceful Frontend+Backend Software Library Suite.
https://hestia.zoralab.com
Other
19 stars 1 forks source link

Add New PWA's Maskable Icon #41

Closed hollowaykeanho closed 1 year ago

hollowaykeanho commented 1 year ago

Description

Please provide a short description of what feature you're looking forward to
enhance below. Please include the story behind your idea as well to give a
better visualization of your idea.

A new icon was introduced:

  1. https://developer.chrome.com/docs/lighthouse/pwa/maskable-icon-audit/?utm_source=lighthouse&utm_medium=devtools
  2. https://web.dev/maskable-icon/
  3. https://w3c.github.io/manifest/#icon-masks

It affects the latest android devices. Let's add them in.

The image design is completely different from the current monochrome maskable icons. We will have to look into the case.

Expected Behavior

Please specify the expected behavior of your requested enhancement. Some great
and helpful pointers are your expected interface (e.g. command patterns,
simple sketches of the user interface, etc).

Maskable icon is automatically generated.

Current Behavior

Please specify the current behavior (e.g. workaround, blockage, etc).

Maskable icon is not supported.

Attachment

Please drag and drop the necessary data files (e.g. screenshot, logs, etc)
below.
hollowaykeanho commented 1 year ago

implemented in ad4758e7a5891aaed13f51cf1c7b733c1a533aad

hollowaykeanho commented 1 year ago

Released in https://github.com/ZORALab/Hestia/releases/tag/v1.0.0