search

ZOSOpenTools / gitport

Apache License 2.0
10 stars 4 forks source link

Revert back to set instead of overrideset for GIT_TEMPLATE_DIR and GIT_EXEC_PATH #95

Closed IgorTodorovskiIBM closed 10 months ago

IgorTodorovskiIBM commented 10 months ago

CW witnessed the following issue:

 /home/opnzos/zopen-20231021/usr/local/zopen/git/git-2.41.0.20231020_134608.zos/libexec/git-core/git-sh-setup: line 46: /home/opnzos/zopen-20231021/usr/local/zopen/git/git-2.41.0.20231020_134608.zos/libexec/libexec/git-core/git-sh-i18n: EDC5129I No such file or directory.
/home/opnzos/zopen-20231021/usr/local/zopen/git/git-2.41.0.20231020_134608.zos/libexec/git-core/git-sh-setup: line 84: eval_gettext: command not found

The issue is that it calls a git under /home/opnzos/zopen-20231021/usr/local/zopen/git/git-2.41.0.20231020_134608.zos/libexec/git-core/git (not in bin) and this determined libexec is wrong.

We'll need to rely on set for now. That means that when git is run, it sets GIT_EXEC_PATH, and then calls its libexec tool, but passes down the GIT_EXEC_PATH path.

IgorTodorovskiIBM commented 10 months ago

Did some more investigation, it's reproducible with:

git submodule --quiet foreach

This PR won't fix it, changing to draft

IgorTodorovskiIBM commented 10 months ago

The change to overrideset (force setting the envars) regressed this. Reverting back to set

IgorTodorovskiIBM commented 10 months ago

Lgtm. Is there a test we should add to catch this in the future?

We may want to continue adding these envars to .appenv in case users also have a Rocket GIT environment, in which their envars would override our default values.