iconv.c.patch: I would refactor the z/OS specific code to a separate file
zos.h or zos-util.h. Adding the 'tocode' parameter to the 'convert'
function for all platforms is OK.
Makefile.in.patch: The "SHELL ?= ..." patch cannot be added: This Makefile
needs to stay in POSIX make syntax; GNU make additions are not OK.
The other part, line 18-19, should use a tab for indentation, as usual in
Makefiles.
check-tag.patch: Looks OK. Just a suggestion: Instead of testing the value
of 'uname -s', better test the value of @host_os@ that can be passed from
the Makefile. In GNU, this is the uniform way of getting the canonicalized
string that designates the operating system. With it, the previous methods
(arch, uname, etc.) are no longer relevant.
-I created a zos-tag.h (hope that is ok) and moved z/OS code to there
-I removed the SHELL ?= patch
-I changed the code to use @host_os@ and passed the parm in from Makefile.in
Bruno had requested changes:
-I created a zos-tag.h (hope that is ok) and moved z/OS code to there -I removed the SHELL ?= patch -I changed the code to use @host_os@ and passed the parm in from Makefile.in