ZOSOpenTools / meta

Meta repository to tie together the various underlying z/OS Open Source tools (ZOT) repositories here
https://zosopentools.github.io/meta/
Apache License 2.0
37 stars 26 forks source link

Query bug #590

Closed DevonianTeuchter closed 7 months ago

DevonianTeuchter commented 7 months ago

Fix bug with querying for installed packages from within zopen install/upgrade. zopen-install calls zopen-query directly rather than using the list verb for zopen; the parameters are different for when a "list" action is required - zopen uses the "list" verb, zopen-query uses the "--list" parameter. zopen-install incorrectly specifies "list" rather than "--list" and as such, the list of returned packages can become corrupted. For small setups, this might not be noticeable as the returned list is sanitised, however with a sufficiently long list (like if a "--all" had been used previously), the list of packages will become corrupt and break the upgrade mechanism as well as taking a longer period of time than it should. Full installations might not be upgradeable using the "zopen upgrade" command, packages might need to be manually listed. The find used to determine the installed packages also recurses too deeply, returning huge volumes of data - again, this gets sanitised for processing but takes a long period of time and can cause issues with envvar lengths etc. The zosfind should only now pick up in the current directory after switching to PKGINSTALL In addition, colorization of columns in detailed mode and column headers have been updated and various shellcheck issues resolved.