ZOSOpenTools / meta

Meta repository to tie together the various underlying z/OS Open Source tools repositories here
https://zosopentools.github.io/meta/
Apache License 2.0
37 stars 25 forks source link

zopen-promote issues #663

Closed lbdyck closed 5 months ago

lbdyck commented 5 months ago
  1. man zopen-promote is garbled (via ssh): image

Under OMVS this is generated groff: fatal error: cannot load 'DESC' description file for device 'utf8'

  1. zopen-promote --help displays the entire help - should pipe thru less for easier paging /reading

  2. after it is complete it really isn't - it keeps going: image

But it is really checking things and building the etc/zopen-config - there should be a message along with the spinning /

  1. Ideally would like to be able to select which packages to promote. For example I may only want to promote git and bash along with any prereqs and definitely do not want to promote zopen :)
lbdyck commented 5 months ago

Also - zopen does not list promote as an option and it isn't in the zopen man page.

peter-sylvester commented 5 months ago

On OMVS there is "simply"a line length problem. Longer lines are split and thus scrolled away. One has the "q" or enter option, but there was too much output. Once I had a little thingy to remove the few blanks. Actually, the man command uses escape sequences, and they are not removed in the OMVS dumb terminal. As far as I understand, it is just /bin/man that is called?

MikeFultonDev commented 5 months ago

@lbdyck there are 2 separate problems here. One is zopen-promote not functioning the way you want and one is the man page being garbled. I have opened #665 for the usability issues.

MikeFultonDev commented 5 months ago

Also - zopen does not list promote as an option and it isn't in the zopen man page.

This is on purpose. zopen-promote is still in 'beta testing' 😁 ... We will add it to the main 'zopen' once it's considered fully baked (@DevonianTeuchter fyi)

MikeFultonDev commented 5 months ago

On OMVS there is "simply"a line length problem. Longer lines are split and thus scrolled away. One has the "q" or enter option, but there was too much output. Once I had a little thingy to remove the few blanks. Actually, the man command uses escape sequences, and they are not removed in the OMVS dumb terminal. As far as I understand, it is just /bin/man that is called?

It is a bit confusing, but there are actually 2 'man' programs on z/OS if you install the z/OS Open Tools man program. This is because the z/OS UNIX System Services 'man' under /bin/man is very limited in function and uses proprietary format man pages, so we added in a z/OS Open Tools man tool so that all the Open Source tools we are porting can have their man pages shown. For the most part, z/OS Open Tools 'man' from the man-db package can display both types of man pages (it fails over to the underlying system /bin/man for the man pages provided by z/OS). The only wrinkle is the handful of commands that are in both UNIX System Services and z/OS Open Tools (man is one, and cp is another good example). In those cases, you have to set the MANPATH and run the specific 'man' program if you want the underlying z/OS man pages

MikeFultonDev commented 5 months ago
  1. man zopen-promote is garbled (via ssh): image

Under OMVS this is generated groff: fatal error: cannot load 'DESC' description file for device 'utf8'

  1. zopen-promote --help displays the entire help - should pipe thru less for easier paging /reading
  2. after it is complete it really isn't - it keeps going: image

But it is really checking things and building the etc/zopen-config - there should be a message along with the spinning /

  1. Ideally would like to be able to select which packages to promote. For example I may only want to promote git and bash along with any prereqs and definitely do not want to promote zopen :)

zopen-promote --help 'worked' for me - it completed and didn't keep running. I was able to reproduce the gibberish for man zopen-promote

lbdyck commented 5 months ago

zopen-promote --help does complete but if the ssh window isn't large enough it keeps going until it finishes requiring the user to scroll back up to view the start of the help.

https://github.com/ZOSOpenTools/meta/assets/42328411/d9c78d23-ffd5-4cf8-b6f3-0168fa2c7761

MikeFultonDev commented 5 months ago

That is standard for help I believe. If you want to get more control you can pipe it to more or less eg

zopen-promote —help | more

lbdyck commented 5 months ago

but should the --help work that way or is there a better way :)

peter-sylvester commented 5 months ago

IMHO, there are ways: compare 'curl --help' to 'man curl' , 'curl --verbose help' and 'curl --help all'

MikeFultonDev commented 5 months ago

Fair enough... We can do better. I opened a separate issue: https://github.com/ZOSOpenTools/meta/issues/667