search

ZOSOpenTools / meta

Meta repository to tie together the various underlying z/OS Open Source tools repositories here
https://zosopentools.github.io/meta/
Apache License 2.0
37 stars 25 forks source link

zopen upgrade meta to 0.8.2 changes fstype to default #733

Open depemco opened 3 months ago

depemco commented 3 months ago

Hello,

When upgrading an existing zopen-installation, with fstype ibm (usr/lpp), from meta version 0.8.0 to 0.8.2 the fstype is changed to the default (usr/local/zopen).

The same thing happens when I try to initiate a new instance, with the command 'zopen init -f ibm'. It create a usr/lpp directory with the meta installed in it, but when I install new tools they are installed under usr/local/zopen and not usr/lpp.

In the file etc/zopen/fstype it also says usr/local/zopen, where in my previous installation it says usr/lpp.

I can't fix the problem by just simply changing the content of etc/zopen/fstype to usr/lpp.

IgorTodorovskiIBM commented 3 months ago

It's likely that the zopen init --refresh that gets triggered on a zopen install/update of meta is overwriting etc/zopen/fstype.

We'll need to guard the case where --f is not provided and not overwrite in that circumstance.

DevonianTeuchter commented 3 months ago

We had spoken about removing the capability to install to locations other than the default /usr/local/zopen as there was no indication it was being used nor that anyone found it useful! Obviously someone has used it so as Igor indicates will need to support this more completely.

depemco commented 3 months ago

I made some symlinks as /usr/lpp/git to /usr/lpp/zopen/usr/lpp/git/git so users could specify /usr/lpp/git in certain scripts. And because we use the /usr/lpp it felt closest to home to choose the ibm fs-type (usr/lpp).

But if the answer is to use the usr/local/zopen, I can change the symlinks to this path, now knowing that is going to be the only supported path. Only suggestion is to remove the --fs-type out of the help of zopen init then 😉 Put me on the wrong path for an afternoon here, reinstalling it for a few times 😛

IgorTodorovskiIBM commented 3 months ago

I think it would be simpler for us to support only one fs-type. @DevonianTeuchter , perhaps you can add this to your upcoming change?