search

ZOSOpenTools / utils

Deprecated - Moved to https://github.com/ZOSOpenTools/meta
https://github.com/ZOSOpenTools/meta
Apache License 2.0
3 stars 2 forks source link

Automate shfmt or alternately reject PR merge if not formatted for 'sh' and 'bash' code #14

Open MikeFultonDev opened 2 years ago

MikeFultonDev commented 2 years ago

Do you need to run shfmt here?

_Originally posted by @IgorTodorovskiIBM in https://github.com/ZOSOpenTools/utils/pull/12#discussion_r890148783_

MikeFultonDev commented 2 years ago

We should be running shfmt on the code in various repos. Should we:

MikeFultonDev commented 2 years ago

Opinions @IgorTodorovskiIBM @fanbo-meng ?

IgorTodorovskiIBM commented 2 years ago

We could set up a Github Action like https://github.com/marketplace/actions/super-linter that checks for any linting errors on new PRs. Super-linter appears to support shfmt

MikeFultonDev commented 2 years ago

@IgorTodorovskiIBM does this one make sense for you? I'm assuming this would require 'special powers' under github?