ZPTXDev / Quaver

Simple-to-use music bot with features such as bass boost, nightcore, seek, search, and more.
https://go.zptx.dev/InviteQuaver
GNU General Public License v3.0
6 stars 3 forks source link

Lavaclient event handlers listening to deprecated event names #1123

Open xayanide opened 6 months ago

xayanide commented 6 months ago

Describe the bug

As of Lavaclient v5.0.0, there were changes to event names. https://github.com/lavaclient/lavaclient/pull/87

This was probably overlooked in https://github.com/ZPTXDev/Quaver/commit/57fb40d935528badca0dad229acf3a7dad99a1fc

This results in a bug where Quaver's lavaclient event handlers for connect and disconnect to not work.

connect should now be connected disconnect should now be disconnected https://github.com/ZPTXDev/Quaver/blob/aec3415b10d3a2856d0cbe82b0a3207eb0fed30c/src/events/music/connect.ts#L11 https://github.com/ZPTXDev/Quaver/blob/aec3415b10d3a2856d0cbe82b0a3207eb0fed30c/src/events/music/disconnect.ts#L4

File names should follow the change respectively.

I learned about some new events in Lavaclient that might come in handy later: The ready event The queueCreate event.

Severity

Low

Affected branches

Quaver version

7.0.1

Steps to reproduce

  1. Start Quaver

Expected behavior

Show an indication that Lavalink has either connected or disconnected.

Actual behavior

No indication.

Relevant log output

No response

zptx-bot commented 4 months ago

:tada: This issue has been resolved in version 7.0.2-next.2 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket:

zptx-bot commented 4 months ago

:tada: This issue has been resolved in version 7.0.2 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket: