search

ZQPei / patchmatch_inpainting

Implementation of PatchMatch for image inpainting in cpp
Other
48 stars 10 forks source link

LICENSE? #4

Closed zvezdochiot closed 4 years ago

zvezdochiot commented 4 years ago

Maybe https://github.com/ImageProcessing-ElectronicPublications/gimp-plugin-colors-bimod/blob/master/LICENSE ?

PS: Just asked

ZQPei commented 4 years ago

How about you make a pull request?

zvezdochiot commented 4 years ago

First need to know the preferences. Is there a need for PR? Detail breakdown by commits?

ZQPei commented 4 years ago

In fact this code has a hidden bug. If process one image at a time, it is fine. However, if you change the main function to process hundreds of images in a folder at the same time with a for loop, it will run out of memory, which means there are somewhere that forget to free memory after alloc and this bug is negligible when processing one image. I tried to find this bug, but failed. That is why I do image inpainting one by one. How about you have a try to go?

zvezdochiot commented 4 years ago

Memory alloc? We will see.

But why not use the "simple" cli? And to work with an array through bash? And the total log is not needed, it is about nothing.