search

ZSShen / ProbeDroid

A SDK for the creation of analysis tools without obtaining app source code in order to profile runtime performance, examine code coverage, and track high-risk behaviors of a given app on Android 5.0 and above.
MIT License
197 stars 37 forks source link

Fix some minor error while building engine jni part #2

Closed Bletchley13 closed 8 years ago

Bletchley13 commented 8 years ago
  1. change file name org_probedroid_Instrument to org_probedroid_instrument to match makefile
  2. Temporary fix "shared library text segment is not shareable" problem by adding LOCAL_DISABLE_FATAL_LINKER_WARNINGS
ZSShen commented 8 years ago

Thanks for the patch!

Currently, this is a work around to silence the PIC warning.

I am now rewriting the machine dependent assembly.

Hope that the issue could be solved more gracefully.

By the way, could you fix some tiny convention issues listed in the comments and resubmit the patch again?

So that I can directly merge it without modification.

Bletchley13 commented 8 years ago

This two problems are fixed in commit d0380a9 https://github.com/Bletchley13/ProbeDroid/commit/d0380a9328baf65c638b4a7795332fee9f27a9ca

Bletchley13 commented 8 years ago

Remove the extra space in Android.mk LOCAL_DISABLE_FATAL_LINKER_WARNINGS := true

ZSShen commented 8 years ago

Ready to be merged.