ZTL-ARTCC / Current_Website

vZTL's Official Website
4 stars 7 forks source link

#538 Realops: Bid multiple flights #569

Closed kjporter closed 2 months ago

kjporter commented 2 months ago

This PR will:

iccowan commented 2 months ago

@kjporter If you can rebase this with main, I'll QA this now that #556 is merged

iccowan commented 2 months ago

QA notes

kjporter commented 2 months ago

QA notes

  • When bidding for flights, if a flight is already assigned I'm able to bid for it. Then when I remove my bid from that flight it removes it completely essentially allowing overwriting of existing bids by anyone (try bidding for a flight that I've bid for in QA2)

    • This is also an issue on the admin panel

Thanks - that's a great catch! Issue fixed in both the bidding and admin views: image image

iccowan commented 2 months ago

QA notes

  • When bidding for flights, if a flight is already assigned I'm able to bid for it. Then when I remove my bid from that flight it removes it completely essentially allowing overwriting of existing bids by anyone (try bidding for a flight that I've bid for in QA2)

    • This is also an issue on the admin panel

Thanks - that's a great catch! Issue fixed in both the bidding and admin views: ...

The issue is partially fixed. I'm still able to directly try to bid for the flight with copying and pasting the URL and changing the ID to another flight that's assigned, so let's add some backend validation with this.

Also a really small issue: When hovering over the assign button on the admin dash it still shows the tooltip. Can we hide this when it's disabled? image

kjporter commented 2 months ago

@iccowan PR updated.