search

ZUGFeRD / mustangproject

Open Source Java e-Invoicing library, validator and tool (Factur-X/ZUGFeRD, UNCEFACT/CII XRechnung)
http://www.mustangproject.org
Apache License 2.0
168 stars 99 forks source link

Support for Jakarta and PDFBox 3.x #393

Closed phax closed 1 week ago

phax commented 2 weeks ago

@jstaerk please find attached a PR that uses Jakarta instead of javax and also updates to PDFBox to 3.x (required because PDFBox 2.x uses javax.).

All unit tests pass in the IDE.

One thing I needed to do, is to disable compression in the created PDFs so that the metadata tests work. I propose to remove this test and enable PDF compression instead....

I also took the liberty to change the version to 3.0.0-SNAPSHOT because it's a lot of breaking changes...

Edit: Updating the VeraPDF dependency from validation-model to validation-model-jakarta resolved the last issue I found (see https://github.com/veraPDF/veraPDF-library/issues/1314)

jstaerk commented 2 weeks ago

Very much appreciated, thanks, I believe I read you had been in vacation already, I still am away this week. But it wont be forgotten.

phax commented 2 weeks ago

@jstaerk enjoy your vacation :)