ZUGFeRD / mustangproject

Open Source Java e-Invoicing library, validator and tool (Factur-X/ZUGFeRD, UNCEFACT/CII XRechnung)
http://www.mustangproject.org
Apache License 2.0
175 stars 100 forks source link

Misc optimizations #406

Closed phax closed 2 weeks ago

phax commented 2 weeks ago
jstaerk commented 2 weeks ago

cosmetical question: debCN, debCurrentChild sounds like "deb"ug? setOwnTaxID etc will continue to work? You might have noticed that I would very much like to publish as (backward compatible) Mustang 2.12 not yet Mustang 3. I would like to close this branch and only accept the new ZUGFeRD version when release, if there are further bigger refactorings or changes maybe we could start a 2.13 branch.

phax commented 2 weeks ago

@jstaerk well, I just reused the deb variables, as a performance improvement - they all existed beforehand. Do you want me to rename them to not contain deb? The setOwnTaxID methods etc. are of course still working. They are just marked as deprecated, so I replaced them with functionally-equal non-deprecated methods :) Hope that solves your questions.