ZUGFeRDimporter does not suport UBL

ZUGFeRD / mustangproject

Open Source Java e-Invoicing library, validator and tool (Factur-X/ZUGFeRD, UNCEFACT/CII XRechnung)

http://www.mustangproject.org

Apache License 2.0

234 stars 132 forks source link

ZUGFeRDimporter does not suport UBL #435

Open jstaerk opened 3 months ago

jstaerk commented 3 months ago

the XPath for the getter methods like getAmount or getDueDate in ZUGFeRDimporter are written for ZF1 and ZF2 and don't yet support UBL, but in ZUGFeRDinvoiceImporter it works.

To prevent redundancy maybe one should reverse the inheritance and instead of ZUGFeRDInvoiceimporter inheriting from ZUGFeRDImporter it could be the other way around, in which case instead of writing XPath one could just return the according attributes of the parsed Invoice object.

jstaerk commented 2 months ago

Most important methods

[x] getIssueDate()
[x] getDueDate()
[x] getInvoiceId()
[x] getAmount()
[ ] getTaxpointDate()
[ ] getHolder()
[ ] getSellerTradePartyAddress()
[x] getIBAN()
[ ] getBIC()
[ ] getBankName()
[x] getBuyerTradePartyName()
[ ] getBuyerTradePartyAddress()
[x] getBuyertradePartySpecifiedTaxRegistrationID()

jstaerk commented 2 months ago

tradeparty should be able to have or deliver a postaladdress? Anyway we need to test that more thoroughly (maybe even in master, so that we can compare?), e.g. with https://github.com/ZUGFeRD/corpus/blob/master/XML-Rechnung/CII/not_validating_full_invoice_based_onTest_EeISI_300_CENfullmodel.cii.xml