search

ZXY101 / mokuro-reader

A mokuro reader written in svelte
https://reader.mokuro.app/
GNU General Public License v3.0
68 stars 19 forks source link

Added color to swipe threshold slider #10

Closed hmellin97 closed 10 months ago

hmellin97 commented 10 months ago

Added orange color to the swipe threshold slider, to make it more UI-friendly.

vercel[bot] commented 10 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
mokuro-reader ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 22, 2024 8:03pm
ZXY101 commented 10 months ago

Thanks for the PR but styling range sliders is a bit of a headache, just setting the background colour isn't a great solution since it looks different depending on the browser. This change is quite an eyesore on firefox for example.

If you really want to update the styling for this then you'll probably have to play around with https://developer.mozilla.org/en-US/docs/Web/CSS/::-webkit-slider-thumb and https://developer.mozilla.org/en-US/docs/Web/CSS/::-webkit-slider-runnable-track and do browser specific styling to ensure it still looks alright in firefox.

hmellin97 commented 10 months ago

Thank you for response. You are right, it does not look good in firefox. I had not considered other browsers.

Thank you for pointing me to good resources, if I find the time I will look into that :)