ZXY101 / mokuro-reader

A mokuro reader written in svelte
https://reader.mokuro.app/
GNU General Public License v3.0
68 stars 19 forks source link

Hidden text "Volume" gets included in the {cloze-suffix} #7

Closed precondition closed 6 months ago

precondition commented 11 months ago

While mining words that appear at the end of speech bubbles, I noticed that the word "Volume" keeps getting added into the Sentence field of my Anki cards.

I noticed the same problem happened across different volumes of the same series I was reading (namely Shadow House [Upscaled]), so I searched for the word "Volume" in the HTML source of the reader and I found this div: offending div I could confirm that this is what YomiChan was picking up by editing the contents of the tag and seeing my modifications appear on new cards I made.

Example of an affected card ![image](https://github.com/ZXY101/mokuro-reader/assets/57645186/1aeb44bf-39e4-47da-8d45-1b4996c599ab)
ZXY101 commented 10 months ago

Yeah I've experienced this before, but it actually seems to be more an issue with Yomichan. I managed to recreate this on another website, essentially yomichan is grabbing the text from the notification toast.

I'm not actually sure where yomichan is grabbing the text from in your case though, their shouldn't be any toast with the text "Volume" in the code base, so it might be grabbing the text from the settings menu? That seems to be the only place that text should be visible in the reader.

walteranderson commented 8 months ago

This looks to be related to sveltekit's accesibility feature "Announcing the page change", which is pretty undocumented but I found this issue that describes it. Doesn't seem like there's any way of hiding or removing it.

I wonder if there's some way of indicating to yomichan/tan where the sentence boundaries are more explicitly?

ZXY101 commented 6 months ago

Closing for now, for the time being just adjust your yomitan/yomichan termination characters.