search

ZZ-Cat / CRSFforArduino

An Arduino Library for communicating with ExpressLRS and TBS Crossfire receivers.
GNU Affero General Public License v3.0
162 stars 27 forks source link

refactor(rc channels): Improve readability of RC Channels in Serial Plotter #40

Closed Kristabel28 closed 1 year ago

Kristabel28 commented 1 year ago

Minor modifications to the Arduino example codes channels.ino and gps_telemetry.ino

Serial.prints more channels. Not sure if I did it right, but I have set it to Serial.print all the channels, based on the channel count crsfProtocol::RC_CHANNEL_COUNT

Arduino serial plotter compatibility for easier readability

image

Hope this is useful to you!

(did i do it right?)

ZZ-Cat commented 1 year ago

Yup. Looks good to me. =^/.^=

FYI: My automations on your PR are janking out on me, and I don't know why. It says "Waiting for status to be reported", but when I check on the actual automations it tells me that it's finished with no tasks. IIRC, this is something on my end that needs to be figured out in the CI/CD side of things.

For the time being, I'm gonna go ahead and move this PR forward through to the Main-Trunk, 'cause I read your code and it looks all good. To answer your question: You did fine. =^/.~= Very well done on your first Pull Request.