ZZ-Cat / CRSFforArduino

An Arduino Library for communicating with ExpressLRS and TBS Crossfire receivers.
GNU Affero General Public License v3.0
154 stars 27 forks source link

Example CRSFforArduino example "rc_channels" not working, Library not installing correctly, no simple way to enter or change Rx/Tx pin numbers, not enough validation or testing before releasing. #97

Closed SB-JHL-B26 closed 8 months ago

SB-JHL-B26 commented 8 months ago

Is there an existing issue for this bug?

What development environment are you using?

Arduino IDE

What board are you using?

Adafruit Feather ESP32

What part of CRSF for Arduino is this bug related to?

Build/Compile/Upload

Current behaviour

The above Arduino IDE v2.x.x instructions to not work using the Add .ZIP Library function. It does work by extracting the ZIP and manually moving the CRSFforArduino-1.0.1 folder to the ".../Arduino/libraries" folder.

The code does compile now. However, there is no output for the rc_channels example. there is no serial monitor output such as "CRSF for Arduino initialisation failed!" or "RC Channels Example" or "Ready" as you might expect by reading the example code.

There is no Serial1.begin such as Serial1.begin(420000, SERIAL_8N1, D0, D1); in the setup() and no comments in the code where to configure the Rx/Tx Serial1 pins. I could not find any documentation that provides information to set up the board UART that is wired to the ELRS Rx.

I am using an Arduino Nano ESP32 connected via a USB port. My hardware setup works perfectly right out of the box with the AlfredoCRSF library once the Rx and Tx pins are changed to "crsfSerial.begin(CRSF_BAUDRATE, SERIAL_8N1, D0, D1);". This line of code is right in the setup() and easy to spot.

I am using a RadioMaster TX16S with a RadioMaster RP 2 Rx. My hardware test setup work perfectly with the AlfredoCRSF library.

At this point, I do not know what else I can do to help. What is required is more pre-release testing to ensure that a user can simple load a library and run an example and have it work right out of the box. Unfortunately, this has not been my experience. I read similar comments from another thread.

At some point down the road I will pick this up and do some more testing again should there be a 1.1 release.

Expected behaviour

A working example

Steps to reproduce

See above.

Additional information

No response