What's the rationale for having `pint` in here?

Zabamund / wellpathpy

Well deviation import

GNU Lesser General Public License v3.0

78 stars 28 forks source link

What's the rationale for having `pint` in here? #45

Closed kwinkunks closed 3 years ago

kwinkunks commented 3 years ago

Pint doesn't seem to be doing much to earn its keep. Are there plans to incorporate unit conversion etc?

If not, may I suggest dropping it from the requirements and letting the user worry about it?

If I have attached units to things, I think it should 'just work' -- maybe except where you strip them out in convert.py. (That module is 42 lines, but really just does a unit conversion, which is 1 line of code.)

Zabamund commented 3 years ago

Thank you Matt, PR #46 agrees with your issue and drops pint. Wellpathpy now only depends on numpy.