Zabooby / firefox-config

My Firefox configuration
12 stars 0 forks source link

Toolbar color is not applied unless Firefox Color is installed #1

Closed ghost closed 6 months ago

ghost commented 6 months ago

Description

Seems like a bit of a weird error as the toolbar color --toolbar-bgcolor doesn't seem to be applied unless you have the Firefox Color extension installed. I'm not sure what steps are needed to fix this as I'm not knowledgeable in Firefox CSS ricing.

Tested on

Steps to Reproduce

  1. Installing everything without having the Firefox Color extension: image
  2. Installing the Firefox Color extension, and selecting a theme: image

Notes

The background area of the window actions are overridden by Firefox color (selecting a textured background will show). This toolbar color issue was also present in another updated version of FlyingFox by Astromations.

** Just as a quick edit: There may be other things that aren't applied unless the Firefox color extension is installed such as Google search suggestion: image

Zabooby commented 6 months ago

Did a bit of testing, the toolbar colours all work when I install on a fresh profile. If you enable the system dark theme the toolbar issue should be fixed so at least you don't need to install Firefox Color extension.

Are you experiencing the issue on both Windows and Arch?

I have noticed the search suggestion doesn't apply the correct colours too, I'll look into it (and some other bugs I've noticed once my exams are over.

Also i just remembered from your screenshots that my config has custom fonts that I haven't added to the repo yet, thanks for the reminder.

ghost commented 6 months ago

I'm experiencing the issue on both Windows and Arch, although setting the system dark theme did fix the toolbar so thanks for the fix there. I don't have the font issue on Arch, but I'd have to check what the default font is there (it's definitely not a serif font, I did install noto-fonts while installing Firefox)-- it defaults to Times New Roman on windows.

Zabooby commented 6 months ago

Could you install the the fonts I just added and see if displays properly?

Can I close this issue as you no longer need the extension to fix the toolbar?

ghost commented 6 months ago

Yup, the fonts work!