Zabooby / mpv-config

Personal mpv config files aiming to get the best quality and viewing experience
https://mpv.io
290 stars 17 forks source link

A few features i recommend #14

Closed handy1928 closed 1 year ago

handy1928 commented 1 year ago

Hi, I forked your config and did a lot of changes. I did it for me personally but now after putting a lot of time into it, I think you should check it out for yourself and see if some features I implemented would be a good idea for your config.

I don't plan on making a pull request because I changed so much, especially I removed stuff you would not remove etc.

Just try it out. My recommendations for your script would be:

Zabooby commented 1 year ago

I've actually been keeping an eye on your fork since you made it, it's been interesting to see the differences in our preferences. Saying that, there a definitely a few things I might add. I'm currently working on various (small) updates, but after that I'll take a proper look and implement some of your changes, (we can discuss details here later).

In regards to your recommendations:

Just curious, what made you fork my config out of all the repo's you could have chosen?

handy1928 commented 1 year ago

Very cool,

I previosly used mpv.net, mostly because of the menu and the ability to view all tracks at once with mediainfo (bitrate). That is because i have files with multiple audio video sups tracks that are easily classifiable with the diffrent bitrates.

Because mpv.net is not really under developement anymore and i had time to spare now. I looked around if i could make the switch to mpv with scripts and not rely on a third party executable. I chose your repo because it had already a working good initialized uosc with not too much other clutter i would have to remove, because i would not need it. And i did not want to start with just a clean uosc because there probably are a ton of qol stuff you added and options you set, which i would have to do a lot of extra work and time to get a feature rich usable gui. So i just added the stuff myself which i found nowhere else. From there it was actually my first time really diving into mpv lua scripting and understanding how everything works. So that was fun xD.

Maby i will make a PR to uosc with the 2 things when i have the time.

Zabooby commented 1 year ago

Yeah I've spent way too much time tweaking uosc, it's great to see loads of people liking it!

I really only uploaded my setup to GitHub as a backup (back when I had no clue what I was doing) seeing the repo have almost 100 stars now is wild to me.

Zabooby commented 1 year ago

I've spent some time using your config and these are the stuff I'll add to my config:

I noticed you added the cycle-denoise script, you should replace it with the shaders from here they have way better results.

handy1928 commented 1 year ago

Thank you for testing and the advice. I plan on making a PR but not that soon, so if you want the feature now i suggest you write it yourself from my code.