Include isort config in first_party detection

Zac-HD / shed

`shed` canonicalises Python code. Shed your legacy, stop bikeshedding, and move on. Black++

https://pypi.org/project/shed/

GNU Affero General Public License v3.0

342 stars 23 forks source link

Include isort config in first_party detection #103

Closed SimonBiggs closed 11 months ago

SimonBiggs commented 11 months ago

Fix for https://github.com/anthropics/anthropic/pull/25819

jakkdl commented 11 months ago

(that repo/issue is not publicly visible)

SimonBiggs commented 11 months ago

Ahh, sure thankyou. Key issue was that shed does not obey the isort.cfg file and instead tries to determine the first party by itself. And the first party attempt isn't always reliable. So ideally at least an isort.cfg can be used in place of it.

This PR enables the use of an isort.cfg file to define known first party.

Zac-HD commented 11 months ago

I'm going to decline this, because we're aiming to move over to ruff instead soon - see e.g. #101. Will coordinate over on the other issue about that.