Closed jakkdl closed 1 year ago
Huh. If base isort
does that we should report upstream and then bump shed
's required version once it's fixed. If not, then we should have some "run again if
Ah, it's autoflake
getting run after isort
that's the culprit here. I opened https://github.com/PyCQA/autoflake/issues/229 - so we either wait for that to be resolved, and/or have shed run autoflake before isort
.
Doing the latter I think also fixes #75, but maybe there's some other reason you opted to run isort
before autoflake
.
Probably no reason, let's just swap the order 👍
https://github.com/PyCQA/autoflake/pull/232 is now merged - so the temporary fix of running isort twice can be removed as soon as a new version is released
another instance of isort shenanigans making shed require two passes:
So in the first pass it removes
Any
, but also sorts the imports lexically - except on the second pass it resorts them with constants first, then lexically.