search

Zacchua / pe

0 stars 0 forks source link

Allows duplicate class name with different cases #2

Open Zacchua opened 2 years ago

Zacchua commented 2 years ago

Teachbook allows two classes which have the same name that have different cases eg. 4E2, 4e2. These are likely to be the same class. However it was mentioned in the UG that names are case and space sensitive and therefore it is classified as a feature flaw

Screenshot 2021-11-12 at 4.24.55 PM.png

nus-pe-bot commented 2 years ago

Team's Response

This bug is a duplicate because it is still referring to the case sensitivity validation in class names(, which is actually a feature decided by our team.)

It is mentioned in UG that names are case and space sensitive. That’s exactly why you can have two classes with the same name but have different cases.

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

Case sensitivity of select command

Steps to reproduce bug:

  1. type select 4e2

Expected output: details of all students from the class 4E2

Actual output: error message saying class does not exist

image.png

Reason for bug report : Although it is mentioned in the user guide that the select command is case sensitive, for all practical purposes this is overzealous input validation. In a real life scenario one may enter 4e2 in a hurry and be met with an error message saying that the class doesn't exist. This issue becomes worse if the class names are longer.

[original: nus-cs2103-AY2122S1/pe-interim#5707] [original labels: type.FeatureFlaw severity.Medium]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

Thanks for the issue. Firstly, our team don’t think this is an overzealous input validation because we have designed the class names to be case sensitive when they are added into TeachBook, and we would like to use capital and lowercase letters to differentiate the two classes. Furthermore, if you really want to consider this as a feature flaw, we think it is of low severity because this is unlikely to affect teachers’ normal use of the app and only appears in rare situations: 1) under normal situations, teachers can be very familiar with class names, and it is not easy to type wrongly 2) if a user finds a class name is too long/strange to type out, he/she can always edit it to become a simpler one.

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: [replace this with your explanation]

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: [replace this with your explanation]