Zacchua / pe

0 stars 0 forks source link

Phone numbers do not allow country codes #4

Open Zacchua opened 2 years ago

Zacchua commented 2 years ago

Screenshot 2021-11-12 at 4.41.23 PM.png

Editing the json file to add in country code makes it fail. Furthermore, format of phone input not specified in UG.

nus-pe-bot commented 2 years ago

Team's Response

Thanks for the issue. Firstly, we change the bug type to feature flaw because the function works as specified/expected (i.e., the behaviour does not contradict with UG or any description of the feature). Instead, it is more likely to be a missing feature from the app. However, we decide to classify the bug as not in scope because we did not plan in v1.4 to implement a feature to accommodate special characters in phone numbers (‘+’, ‘-’, ‘ ‘). In our opinion, such a feature is not essential for the app to be useful because it is possible to store phone numbers using only digits and it is also commonly used. For example, “+65” can be stored as “065”. Besides, we did not specially mention the format of a phone number in UG because we think it is nitty-gritty detail and we expect users to get the information from the error message when they are attempting to add an invalid phone number into the app (not by editing the data file though). Furthermore, since we have a warning message in UG to remind users they should take caution when editing the data file, we expect them to be already familiar with the format of every field at the time when they are doing this. With these, we consider the feature flaw, not in scope.

Items for the Tester to Verify

:question: Issue response

Team chose [response.NotInScope]

Reason for disagreement: [replace this with your explanation]


:question: Issue type

Team chose [type.FeatureFlaw] Originally [type.FunctionalityBug]

Reason for disagreement: [replace this with your explanation]


:question: Issue severity

Team chose [severity.Low] Originally [severity.VeryLow]

Reason for disagreement: [replace this with your explanation]