Zacchua / pe

0 stars 0 forks source link

Same person in different class allowed #5

Open Zacchua opened 2 years ago

Zacchua commented 2 years ago

Screenshot 2021-11-12 at 4.55.24 PM.png Screenshot 2021-11-12 at 4.55.30 PM.png

According to UG, duplicate people are defined as having the same name. In the above two screenshots, the person "Alan Tan" (with the same name, phone, address) is added to both 4e2 and 3E2. This should not be possible as this app is catered towards primary and secondary school teachers, and students cannot be part of two classes at the same time.

Can be an issue for teachers who manage multiple classes.

nus-pe-bot commented 2 years ago

Team's Response

Thanks for the issue. We reject this bug because it is totally an expected and correct behaviour, and we have designed the feature to be like that. We don’t think it is mentioned anywhere in UG that duplicate students cannot exist in the TeachBook at the same time. Under the “add” command section in UG, we are explicitly saying that “The NAME is case and space sensitive and should not be already inside the class.” In fact, students with the same name can be added into different classes and they are not really duplicate. Such a design is also realistic because there can be students having the same name taught by the same teacher but in different classes. On a side note, we do not allow students with the same name in the same class simply because such a chance is very small, but it could cause unnecessary confusion to users if we allow this. As discussed above, we change the bug type to feature flaw from functionality bug because we think the current behaviour is as specified/expected. Lastly, as we don’t think this is a bug at all, we cannot choose a proper severity level.

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: [replace this with your explanation]


:question: Issue type

Team chose [type.FeatureFlaw] Originally [type.FunctionalityBug]

Reason for disagreement: [replace this with your explanation]


:question: Issue severity

Team chose [severity.Low] Originally [severity.Medium]

Reason for disagreement: [replace this with your explanation]