search

ZachJW34 / nx-plus

Collection of Nx Community Plugins
MIT License
300 stars 52 forks source link

feat: add nx 13 support in dep-graph patchers #249

Closed bokub closed 2 years ago

bokub commented 2 years ago

Current Behavior

Running npm run postinstall throws this error with Nx 13.10:

Failed to patch Nx dep-graph for Vue support. 
Error: ENOENT: no such file or directory, open
'/home/<stuff>/node_modules/@nrwl/workspace/src/core/project-graph/build-dependencies/typescript-import-locator.js'

Expected Behavior

npm run postinstall should patch dep-graph builder function to support Vue files.

Related Issue(s)

No issues, but it's an improved version of #246

N.B

The E2E tests are failing, but the last 2 commits on master failed at the same test so I don't think it's related to my PR.

ZachJW34 commented 2 years ago

Thanks for the contribution! I'll look into the failing test, probably a new vite version.

bokub commented 2 years ago

Great :tada:

I've opened #253 to fix the failing tests

konrad-synergy commented 2 years ago

awesome!

paulhobbel commented 2 years ago

A bit late perhaps but technically the patch is no longer needed right? https://nx.dev/extending-nx/project-graph-plugins