search

ZachJW34 / nx-plus

Collection of Nx Community Plugins
MIT License
302 stars 51 forks source link

chore: bump @vue/cli-shared-utils #278

Open Nakroma opened 2 years ago

Nakroma commented 2 years ago

Current Behavior

Trying to install @nx-plus/vue fails with:

error @achrinza/node-ipc@9.2.2: The engine "node" is incompatible with this module. Expected version "8 || 10 || 12 || 14 || 16 || 17". Got "18.12.1"
error Found incompatible module.

on node >= 18. This is because @vue/cli-shared-utils hard relies on version 9.2.2 of @achrinza/node-ipc which only supports node < 18.

Expected Behavior

@nx-plus/vue should install on node >= 18 without errors.

Fixes

Unfortunately, the newest 4.x version of @vue/cli-shared-utils also hard relies on node-ipc@9.2.2. So I bumped the shared utils package to 5.0.8. I couldn't get the e2e tests to work (even without this change), but the unit tests go through. If the maintainers think that the package should stay on 4.x I can create a similiar PR on @vue/cli-shared-utils to bump node-ipc instead.

Nakroma commented 1 year ago

I made a node>=18 version for temporary use if anyone else has this problem, as the maintainers seem busy atm: https://www.npmjs.com/package/nx-plus-vue-node-18