search

ZachJW34 / nx-plus

Collection of Nx Community Plugins
MIT License
300 stars 52 forks source link

Nx moving JS graph building to new location #286

Closed AgentEnder closed 8 months ago

AgentEnder commented 1 year ago

Current Behavior

@nx-plus/vue doesn't use the plugin project graph API that was released in Nx 12.X, instead, it patches part of Nx's code on postinstall. The file that is patched is being renamed on Nx's side of things, so this will break either before v16 or at v16, depending on how we release our changes.

Expected Behavior

@nx-plus/vue uses the plugin project graph API, or at minimum adds the new path to the getPath function inside the patching code. https://github.com/ZachJW34/nx-plus/blob/master/libs/vue/patch-nx-dep-graph.js#L28

Steps to Reproduce

  1. Check out the branch from https://github.com/nrwl/nx/pull/15365 and attempt to use @nx-plus/vue's graph support on a codebase with that branch's code installed
  2. Note error.
AgentEnder commented 8 months ago

Im going to close this out since v17 of nx has first party support for vue.