ZacharyDuBois / Fluid-MC-Stats

A web interface for the Stats plugin.
Other
5 stars 5 forks source link

Fluid Stats Web Installation Fault #11

Closed Adzkii closed 9 years ago

Adzkii commented 9 years ago

Few installation bugs, After clicking "install" it takes me back to the same install page, Also yes I've filled in everything that is * required too? Sorry if i'm missing anything out, Point it out :)

ZacharyDuBois commented 9 years ago

Are you using Apache or Nginx? Also, is anything appearing in the error log? It should only do that if it can't write the config.php file.

Adzkii commented 9 years ago

Yes I'm using a dedicated server (Apache), But i never had a problem with the older version Fluid Stats, I always take few mins to re-check everything before installing, also I have gave 755 and 7777 permissions to specific file/folder like it stated?

ZacharyDuBois commented 9 years ago

There is a redirect in inc/security,php that checks for the MySQL credentials. So, I'd make sure the config was written. Other than that, I'm currently at school. I could test it in a few hours during lunch. Thanks for the report because there are a few installer issues that I need to fix.

Adzkii commented 9 years ago

Sure i'll check it out, and report back :) Like always

krustymk commented 9 years ago

Try adding the server port number, this caught me out, some genius put the top SQL port number in but used a jpg of the number for the server, you have to type over it.

ZacharyDuBois commented 9 years ago

@krustymk, it is a placeholder, not an image. Some people and server hosting providers run their MySQL/Maria instance on a different port. I could have it default because that is the standard port for it. 75 more minutes until I have lunch to look at it. :)

lippoliv commented 9 years ago

Didn't I fixed it implicit with my work on the installer? Had the same issue.

@krustymk: Did you used the sources here or the last release?

Am 2014-12-16 16:44, schrieb Zachary J. DuBois:

@krustymk [1], it is a placeholder, not an image. Some people and server hosting providers run their MySQL/Maria instance on a different port. I could have it default because that is the standard port for it. 75 more minutes until I have lunch to look at it. :)

Reply to this email directly or view it on GitHub [2].

Links:

[1] https://github.com/krustymk [2] https://github.com/DevelopGravity/Fluid-MC-Stats/issues/11#issuecomment-67179153

ZacharyDuBois commented 9 years ago

Also, just thinking of this, IIRC the MySQL port field is required and should cancel the form submission. So if it submitting blank, I will really need to take a look.

krustymk commented 9 years ago

Placeholder jpg... does it really matter? To the person installing using a default port it looks like its already entered like the SQL port is! Either make it blank so its obvious you need to enter a number and dont think its auto completed or have the port number present that a user can change like the above port. Not have 2 port fields and treat both different......

ZacharyDuBois commented 9 years ago

@krustymk, turns out, there is already a value setup on it and it is autofilled on my test environment. Going back to the original issue, @Adzkii is the config.php filled with all the values you entered on the installer? The only time it will redirect you to the installer is when $mysql_host is not set.

ZacharyDuBois commented 9 years ago

@lippoliv, This repo is an exact copy of the old one so, all your changes should be here :)

krustymk commented 9 years ago

Well on my install it needed to be filled in, i got the same error the chap above got and it wasnt until i put my cursor in the box that i see it wasnt real text

krustymk commented 9 years ago

Fluid-MC-Stats-master is the one i used

ZacharyDuBois commented 9 years ago

Line 141 of install.php shows it is filled in and it has a placeholder as well. <input name="mysql_port" type="text" class="form-control" id="mySQLHostPort" placeholder="3306" value="3306" needed>

krustymk commented 9 years ago

The 25565 port not the SQL... are you reading the messages?!

ZacharyDuBois commented 9 years ago

@krustymk, try that?

ZacharyDuBois commented 9 years ago

I think my fix in issue #12 might have fixed this. I am not sure. Try out the new source, @Adzkii and let me know :)

lippoliv commented 9 years ago

Source Looks nice :+1:

ZacharyDuBois commented 9 years ago

@lippoliv So it all works for you :P

Adzkii commented 9 years ago

Nope unfortunately, Same prob

ZacharyDuBois commented 9 years ago

Hmm, are you running on a shared host or a dedicated and what disto?? Cause I have a command I want you to try.

Adzkii commented 9 years ago

To be honest, i got 5 hosting servers. So i tested it on shared hosting also Dedicated KVM server too. Looks like the problem is on your side mate ;)

ZacharyDuBois commented 9 years ago

@lippoliv are you able to reproduce it? For some reason I cannot.

Expected behavior would be it writes the config and redirects you to a page telling you to remove the installation files.

Adzkii commented 9 years ago

Zachary, i think the older version was much easy to install? But i'll keep trying this one until i get it right (even though i am doing it right lel)

ZacharyDuBois commented 9 years ago

Well you could manually edit the config if you want. But if there is a bug with the installer if like to get it fixed :)

Adzkii commented 9 years ago

You know what? I'll wait for further updates and fixes. I wish i had time to edit and do the fixes but i really can't Christmas is near lol

ZacharyDuBois commented 9 years ago

Alrighty. I will try my best when I get home to reproduce it. :) For now I will mark it as I cannot though.

Adzkii commented 9 years ago

Okay :)

lippoliv commented 9 years ago

I hope I have enough time to test this behavior this evening (8pm GMT+1) but possibly I haven't. Will comment here if I have tested ^^

Will test local WIN8 + XAMPP and online VPS (Debian wheezy + apache2) should be enough to clear out whats going on here ^^

Am 2014-12-18 12:59, schrieb Zachary J. DuBois:

@lippoliv [1] are you able to reproduce it? For some reason I cannot.

Expected behavior would be it writes the config and redirects you to a page telling you to remove the installation files.

Reply to this email directly or view it on GitHub [2].

Links:

[1] https://github.com/lippoliv [2] https://github.com/DevelopGravity/Fluid-MC-Stats/issues/11#issuecomment-67476553

ZacharyDuBois commented 9 years ago

I have currently tested it locally with a MAMP-like setup and on the test site running LEMP.

Adzkii commented 9 years ago

Working for you or not?

ZacharyDuBois commented 9 years ago

Worked perfectly. I don't know if @lippoliv's setup worked.

krustymk commented 9 years ago

Adzkil, try this. Every single data entry box, delete what is in there and retype it. Even if what is in there is what you want. Try it. If you cant delete what is in there, type over it. For example You want to call or you have called your database 'Stats', you look and see its pre-filled and move on... it wont work, because although it looks like its pre-filled its not, there are several data entry points like this! That is begging for install issues making a user think a box is pre filled!! Sort it out!!

Also, your browser may be auto filling some boxs such as your password box with one from your favorite porn site ;)

Oh look, My awesome stats server... id been wondering what to call it, ill leave that in there :)... Oh install has failed... C'mon Zach, either properly filled or blank!

There is no * by 'Display Address' but it is required

ZacharyDuBois commented 9 years ago

@krustymk There are ones with placeholders, and then ones that are already filled with the default, most common option. MySQL port shouldn't be different so it is pre-filled.MySQL username isn't filled because it will be different for everyone. However the display address was a tiny error made by me. I will make sure go through and fix those up in a few seconds.

krustymk commented 9 years ago

You know its a placeholder, the guy/girl installing it doesnt and if the name suits may leave it thinking its real text

ZacharyDuBois commented 9 years ago

@krustymk That does not affect most people. Most people are seeing the difference between the placeholder and what is filled. Most places do it.

krustymk commented 9 years ago

Most places make it obvious its a placeholder and not text!

ZacharyDuBois commented 9 years ago

screen shot 2014-12-24 at 3 15 43 pm There is enough of a difference for most people.

ZacharyDuBois commented 9 years ago

@Adzkii any success? This version will be getting released soon.

ZacharyDuBois commented 9 years ago

Fluid MC Stats v0.2.0 was released.

ZacharyDuBois commented 9 years ago

@Adzkii, No response? I hope your issue was fixed. Let me know if it's not and I'll reopen the issue.