search

ZacharyDuBois / Fluid-MC-Stats

A web interface for the Stats plugin.
Other
5 stars 5 forks source link

Pingr Addition #13

Closed hockeymikey closed 9 years ago

hockeymikey commented 9 years ago

Removes usage of Minecraft-API for online status to use a build in bundled script with Pingr.

ZacharyDuBois commented 9 years ago

Wow! Thanks :) Let me pull this on the test site for a quick run and see how everything works :D I should get back to you in 10-15 minutes.

ZacharyDuBois commented 9 years ago

Seems you didn't add the data to inc/serverstatusui.php :P I'll work on it in a few.

ZacharyDuBois commented 9 years ago

I thought it was going to be a quick fix :( I will have to play with Pingr or find a new API. One or the other :P I'd rather an API that will cache the request so we aren't spamming the query.

ZacharyDuBois commented 9 years ago

Hmm, @lippoliv wanna give it a shot?

hockeymikey commented 9 years ago

Fair enough. What needs to be inc/serverstatusui.php?

I mostly just edited it to get the server status panel working again.

ZacharyDuBois commented 9 years ago

That is what calls the class in inc/serverstatus.php and then displays it. If you look at the history of the changes in commit dd34f07f3e620ef574f70de490df19b4c1f1d355, you should see what I removed when the API we used went down.

hockeymikey commented 9 years ago

Oh yeah, my local installation is of an older version before you removed that so that's why I didn't add it back. I'll edit that later then.

ZacharyDuBois commented 9 years ago

Alrighty. Thanks for the support of the project :)

hockeymikey commented 9 years ago

No problem, thanks for making this and continuing support on it. Added server icon support using Pingr. Tested working fine.

ZacharyDuBois commented 9 years ago

Hmm. I can't get this to work in my dev environment.:( I do have another idea to have this implemented though. I will work on this now.

ZacharyDuBois commented 9 years ago

See how you like issue #17 :)

Hope you like it 'cause I help the 5 o'clock release date to get the caching just right :P

hockeymikey commented 9 years ago

Strange worked fine for me. Glad to see it re-implemented and with the release of v2.0.

Thanks again for all the work you put into this and Happy Holidays!