search

ZacharyKhan / ZKCarousel

A simple carousel implementation written in Swift
MIT License
289 stars 57 forks source link

Is there some control over number of 'dots' shown on carousel? #21

Closed ChrisAldridgeRIT closed 5 years ago

ChrisAldridgeRIT commented 6 years ago

regardless of slides added I always get three dots?

ZacharyKhan commented 6 years ago

I will look into this, it should automatically have the correct number of dots as you add in slides.

ZacharyKhan commented 5 years ago

This is a confirmed bug. I've fixed the issue and pushed update 0.2.1.

Run pod update and make sure you are on release 0.2.1.

ChrisAldridgeRIT commented 5 years ago

I'm still seeing three dots everytime (actual slides I can still swipe through is more its jsut the indicator not right)

Im running proper version Installing ZKCarousel 0.2.1 (was 0.1.8 and source changed to https://github.com/CocoaPods/Specs.git from https://github.com/cocoapods/specs.git)

cheers Chris

ZacharyKhan commented 5 years ago

I'll look into it again, for now I would recommend looking at the updated example project. I have set that to implement 6 slides, with the dots showing correct number for slides.

ZacharyKhan commented 5 years ago

@ChrisAldridgeRIT Not sure what’s going on for you, I’m not able to replicate the bug after update 0.2.1. I am able to download the example project, build and run without issues.

If you would like to post your code that adds the slides, that may provide some insight.

ZacharyKhan commented 5 years ago

Closing due to the fact that everything seems good on my end. I am able to run pod try ZKCarousel in terminal, which downloads and opens version 0.2.1, and the project runs as expected. Dots work correctly relative to the number of slides you feed into the carousel.

netsmith commented 5 years ago

I think its related to the problems I have with the Async loading of the images. NP though, am investigating and will let you know if I spot anything cheers

ZacharyKhan commented 5 years ago

I think its related to the problems I have with the Async loading of the images. NP though, am investigating and will let you know if I spot anything cheers

Let me know if I can do anything to help. As long as you are updating the slides property on ZKCarousel, it should auto-update the page indicator dots.