search

ZacharyKhan / ZKCarousel

A simple carousel implementation written in Swift
MIT License
289 stars 57 forks source link

Autolayout issues with iphone8 and iphone8plus #7

Closed elmz87 closed 6 years ago

elmz87 commented 6 years ago

Hi it seems i have a problem to set the carousel self.carouselImageArr.frame = self.carousel.frame

When i load in iPhone8 it looks fine, however when i load in iPhone8 Plus the carousel does not fill the view.

ZacharyKhan commented 6 years ago

@elmz87 I would suggest using auto layout and NSLayoutConstraints rather than setting the frame.

Would you mind posting a code snippet here?

ZacharyKhan commented 6 years ago

I've updated the carousel to use NSLayout constraints manually rather than using a visual format. Run pod update and make sure you're on version 0.1.5 and let me know if the issue persists or if it's solved with this release.

ZacharyKhan commented 6 years ago

Closing, this should have been fixed in latest release. If the issue persists, please re-open this issue or create a new one.