search

Zachdehooge / NadoBot

A Discord.py bot that pulls nadocast data
3 stars 1 forks source link

Better Image Viewer #15

Open Arch881010 opened 3 weeks ago

Arch881010 commented 3 weeks ago

Currently, the output is 2 lines of code and looks like:

await ctx.send(embed=embed)
await ctx.send(files=files)

image

This could be better (maybe text and embed with buttons to view each image? (as suggested by Zach)).

Arch881010 commented 3 weeks ago

Also please note, the text in the embed is currently accurate (because at the time of posting, as per embed text, the next range of images has not been posted).

Arch881010 commented 2 weeks ago

Given that (we haven't had to handle this yet) another forecast range has been added, we need to figure out how to handle this output better. Nadocast does indeed issue D2 forecasts on some hours, but current code doesn't handle anything beyond D1 (except for the recent commit to #21... and it only includes f12-35). Maybe we need this new viewer sooner than anything else stacked on our TODO list?

Zachdehooge commented 2 weeks ago

Sure! That definitely seems like something that needs to be on top of the list

Zachdehooge commented 2 weeks ago

Can this be closed after that PR?

Arch881010 commented 2 weeks ago

Sadly, no. #21 only fixed an output issue (where instead of just the 2024 model (when MODELS=2024) being returned back, it also returned 2024abs).

Zachdehooge commented 2 weeks ago

No worries!