search

Zack-Tay / pe

0 stars 0 forks source link

ctag command start time can be later than end time #6

Open Zack-Tay opened 7 months ago

Zack-Tay commented 7 months ago

Steps to reproduce

Running the command: ctag t/E-camping dc/camping! sd/2024-04-05 11:59:59 ed/2024-04-05 10:59:59

Expected

Probably return an error because events not supposed to end earlier than its starting

Actual

Application accepts these values

Screenshots

startendTimebug1.png

nus-pe-bot commented 6 months ago

Team's Response

No details provided by team.

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

Create tag command: no error message when user adds an event that ends earlier than it starts

Screenshot 2024-04-19 at 4.51.21 PM.png

There is no warning or error message when users input an event end date that is before the start date. Users could accidentally input the wrong event duration.

[original: nus-cs2103-AY2324S2/pe-interim#4914] [original labels: type.FunctionalityBug severity.Low]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

Yes, it is a bug that we did not caught attention of, but the chances of someone doing this is pretty low so we think the severity is low.

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: This is a separate issue from the one that I raised about date start and end validation as this concerns the time element that the team did not take into consideration or account for.

Basically, even if the team correctly validate and fix the problem that the start date cannot be later than the end date, the issue that the start timing of the event being later than the end timing can still persist.

## :question: Issue severity Team chose [`severity.Low`] Originally [`severity.Medium`] - [x] I disagree **Reason for disagreement:** I stand by the original issue severity of Medium that I gave. This can be an inconvenience to users who entered a start time that is later than the end time. Some problems arise when searching for events using time or when looking through information about a particular event. Furthermore, the time is solely in numbers, and different people can interpret the numbers in different meaning, based on the conventions that they fall back on in the case they forget and so users who may have forgotten the date format used in this application may be misled or confused by their own mistakes.