soc-se-bot
commented
2 months ago Team's Response
No details provided by team.
The 'Original' Bug
[The team marked this bug as a duplicate of the following bug]
Add command: Cannot add contact with same name but different details
Users cannot add a contact with the same name but different details. Perhaps the UG can specify that names of contacts added must be unique.
Commands to reproduce error: add n/Betsy Crowe e/betsy23@example.com a/43 st p/827372 t/friend add n/Betsy Crowe e/betsycrowe88@example.com a/723 street p/837788
[original: nus-cs2103-AY2324S2/pe-interim#4913] [original labels: type.FunctionalityBug severity.Low]
Their Response to the 'Original' Bug
[This is the team's response to the above 'original' bug]
The inability to create 2 contacts with the same name is to prevent you from recording the same person again into the EventBook, whether it is because of change of address, phone number or even gender.
If two person have the same name by concidence, you have to find a way around it (Alex Tan from SoC vs Alex Tan from Engineering or Alex Jr. vs Alex Senior).
However, if you have created 2 Alex with different description when it is the same Alex (POV: Alex moved to a new place recently), then you are having troubles with duplicates of the same person, which is much more troublesome.
Items for the Tester to Verify
:question: Issue duplicate status
Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)
- [ ] I disagree
Reason for disagreement: [replace this with your explanation]
## :question: Issue response Team chose [`response.NotInScope`] - [x] I disagree **Reason for disagreement:** "response.NotInScope" is definitely not appropriate here. It is absolutely plausible that there can be 2 persons with the exact same name, and different email address, in this case, I would not be able to add either 1 of them. Furthemore, I would need to specify additional information about either one of them which I may or may not have at the point in time of adding. An address/contact book certainly needs to take into account being able to add people of the same name as an existing person but with different details, in which case, this team failed to do so.
## :question: Issue severity Team chose [`severity.Low`] Originally [`severity.Medium`] - [x] I disagree **Reason for disagreement:** This is a pretty inconvenient bug (Medium severity) as it would inconvenience users who have to source and dig for more information about the 2 persons in order to differentiate them clearly. This information may not be readily available to users at the point of adding.
Steps to reproduce
Running commands:
Expected
Probably should accept this case as 2 individuals can have the same name but different identity and be 2 different persons.
Actual
Error is thrown saying "This person already exists in the address book".
Screenshots