search

ZackHodari / morgana

Toolkit for defining and training Text-to-Speech voices in PyTorch
https://zackhodari.github.io/morgana/
MIT License
4 stars 4 forks source link

Undeclared dependency on tts_data_tools #1

Open jacobjwebber opened 4 years ago

jacobjwebber commented 4 years ago 
File "/home/jjw/clones/morgana/morgana/data.py", line 9, in <module>
    from tts_data_tools import file_io
ModuleNotFoundError: No module named 'tts_data_tools'

Put in list of deps in setup.py?

jacobjwebber commented 4 years ago

Ah, I had some problems with a pip install, had to do setup.py after cloning tts_data_tools maybe ignore this one

ZackHodari commented 4 years ago

Yes, you need to install as a module first

git clone https://github.com/ZackHodari/tts_data_tools.git
cd tts_data_tools
python setup.py develop

I planned to add both Morgana and tts_data_tools to pypi.org, but have yet to get round to it. When I do add them, it will be possible to add tts_data_tools to the dependencies.

Leaving this issue open until I do so.

jacobjwebber commented 4 years ago

Nice, also (relatedly) from the README

data.NumpyBinarySource('lab', normalisation='minmax'),

throws an exception -- it seems NumpyBinarySource is in data_sources from tts tools

ZackHodari commented 4 years ago

The README and documentation needs updating, for up-to-date examples check the models directory (At some point I'll also add tests to ensure those models stay valid!) https://github.com/ZackHodari/morgana/blob/master/models/f0_test_model.py

Yes, data_sources were moved to tdt(tts_data_tools). This was done as the provided data_sources rely on file_io and other utilities written in tdt. It might be best for me to move the base _DataSource class into Morgana, but that would have made an ugly back and forth dependency which I was worried about. I'm open to changing this.