search

Zackhardtoname / internships

A collection of internship applications in a fancy excel-like website
https://zacklight.com/internships/
944 stars 71 forks source link

adds many more companies #14

Closed coopslarhette closed 5 years ago

coopslarhette commented 5 years ago

and their locations, some details need finishing. may continue to fill out details tmw

Zackhardtoname commented 5 years ago

Wow! Sir. You are truly amazing!! Would you be interested in further (coding-based) collaboration?

appsicle commented 5 years ago

Most of these companies are not actually out yet. I've already tested every link and every company added in this pr is not actually open.

coopslarhette commented 5 years ago

ah yes that is true, I pretty much just pulled them from my own spreadsheet where I had a column indicating whether or not they’re open or closed. could add that if it is wanted but maintenance of that is difficult.

ironsoul0 commented 5 years ago

IMHO, this will ruin the whole repo. What is the purpose of adding companies that do not have open positions yet? In this case, https://github.com/christine-hu/summer-2019-internships is a more convenient resource.

Please revert, @Zackhardtoname

Zackhardtoname commented 5 years ago

I will revert it as soon as I get back tonight. I am really sorry for the trouble! @ironsoul0 @coopslarhette @appsicle

coopslarhette commented 5 years ago

I have more thoroughly looked over christine’s repo and now I can understand why you would want to revert, up to you zack

appsicle commented 5 years ago

The purpose of this repository is to track opened internships, not all internships that will eventually open. Every cs student in the world knows what the top companies are. I can list all the top unicorns, FAANG, trendy startups, and companies off the top of my head forward and backward. The problem is that we aren't aware of when the job posting actually opens and its semi-important to apply early on. By adding every company that does internship programs, that dilutes all the actual open internships. @coopslarhette You had very good intentions with your PR but I think you missed the purpose of this repository.

Zackhardtoname commented 5 years ago

@ironsoul0 @coopslarhette @appsicle I really appreciate coopslarhette's effort in contributing generously to this repo.

I'd also say it's pretty important to apply (as soon as) the position opens. Recruiters often send out interview invitations in rounds and have a fixed number of spots in mind.

I would be more careful in the future when merging pull requests. Thank you guys for bringing this to my attention.

Zackhardtoname commented 5 years ago

Also, if potentially problematic pull requests are closed, I think it's better to open a new issue that refers to the pull request so that people can see the conversation more easily.