search

Zackhardtoname / internships

A collection of internship applications in a fancy excel-like website
https://zacklight.com/internships/
942 stars 71 forks source link

Dictionary added for the states abbreviation #19 #24

Closed MercureTony closed 4 years ago

MercureTony commented 4 years ago

Fixes #19 . By the way, are you still willing to abbreviate the position too?

Zackhardtoname commented 4 years ago

Hi MercureTony, I really appreciate your effort! I think perhaps we don't need to spell out the complete names for the state. At most, we could include a link to a third-party site that contains all abbreviations, right? (and this is still unnecessary in my opinion)

Yes. The position abbreviations would be great. Maybe we are setting the standard for the internet. For that, I think changing the internships.csv and README.md like you did here would be perfect.

Also, we don't have to manually change README.md when we change repo_info.md: it's done in convert_md.py (which I probably would add more comments to when I get the time)

Thank you so much!

MercureTony commented 4 years ago

Alright