Zaczero / osm-relatify

🚍 OpenStreetMap Public Transport Made Easy! — Web Editor
https://relatify.monicz.dev
GNU Affero General Public License v3.0
59 stars 6 forks source link

Support public_transport=station #26

Closed JesseWeinstein closed 1 year ago

JesseWeinstein commented 1 year ago

It seems like only public_transport=platform can be selected, not public_transport=station. This makes it harder to include terminal stops.

Zaczero commented 1 year ago

I don't believe that's a valid case, and there may be some misunderstanding regarding the appropriate usage of this tag.

https://wiki.openstreetmap.org/wiki/Tag:public_transport%3Dstation

The public_transport=station tag is used to identify a railway station, a bus station or any other kind of a public transport station. It will almost certainly be part of a public_transport=stop_area relation which will contain a number of public_transport=platforms, public_transport=stop_positions and other elements.

Meaning, that a station should contain separately mapped platforms. It's simply a large collection, a "station".

I have read:

and none of them properly justify your use case but maybe I am missing something. Feel free to guide me in the right direction by providing me with tag documentation.

Perhaps @osm-ToniE could assist here, as you appear to have more experience in public transport knowledge.

JesseWeinstein commented 1 year ago

Ah, yeah, I think you are right. So it would be nice to have Relatify warn about this mis-tagging.

osm-ToniE commented 1 year ago

I agree.

There are only two objects which represent a stop:

That's all what is allowed for route relations.

In addition to that:

public_transport=station is usually a building (represented by a node, way, area), as known with trains

public_transport=stop_area is an MP grouping all platforms and stop_positions of a vehicle type. So there can be more then one for the same location: one for buses, one for trains, one for subway - each can be assigned a different name. It can also include amenities like ticket vending machines, benches, ...

public_transport=stop_area_group then groups all such stop_area in a single MP

osm-ToniE commented 1 year ago

Ah, yeah, I think you are right. So it would be nice to have Relatify warn about this mis-tagging.

Yep, PTNA does print an error message

Zaczero commented 1 year ago

Thank you @osm-ToniE :smiley:! This will help out a lot in future discussions, releases.

Zaczero commented 1 year ago

Performing validation on other objects is not currently planned for Relatify. The absence of a bus stop is a sufficient indication that something is wrong. :stuck_out_tongue: