Zaczero / osm-relatify

🚍 OpenStreetMap Public Transport Made Easy! — Web Editor
https://relatify.monicz.dev
GNU Affero General Public License v3.0
59 stars 6 forks source link

Duplicated roundabout #32

Open Dimitar5555 opened 1 year ago

Dimitar5555 commented 1 year ago

I'm not sure how or why it might've happened, but the roundabout is somehow duplicated. On the west side it is quite segmented.

image

All other segments are duplicated normally (from one exit/entrance to the next).

image

The duplicate was introduced in https://www.osm.org/changeset/139108622 and I've removed it manually in https://www.osm.org/changeset/139125857.

Zaczero commented 1 year ago

This occurred because two edits were performed in very quick succession, which didn't allow Overpass a chance to synchronize. I believe this issue could be resolved by temporarily storing recent splits in memory and preventing the user from loading a new relation when the database hasn't been fully synchronized. Alternatively, an even more advanced merge logic could be implemented to detect and resolve situations like this.

https://www.openstreetmap.org/changeset/139108512 https://www.openstreetmap.org/changeset/139108622

Thank you for reporting the bug!

mcliquid commented 1 year ago

Through the following MapRoulette challenge, I came across a lot of these errors, mostly by myself and created by Relatify. https://maproulette.org/browse/challenges/39506

Here the initial changeset: https://www.openstreetmap.org/changeset/139253149 Here the fixing changeset: https://www.openstreetmap.org/changeset/141252802

zorun commented 1 year ago

I have seen several instances of this bug in my neighbourhood recently, introduced by another contributor using osm-relatify.

The problem can be described like this:

This is creating a mess in OSM and requires time to clean up, can you at least workaround the problem so that people don't trigger this bug? Like forcing a delay between edits?

Here is an example of duplicated ways exhibiting the issues that I haven't yet fixed:

infeeeee commented 1 year ago

This still happens on a lot of places. Is there any workaround to stop this happening? Hard reload the browser? How much time should I wait between edits?

Zaczero commented 1 year ago

How much time should I wait between edits?

upload -> 3 minutes -> load

Zaczero commented 11 months ago

This issue will be resolved with OpenStreetMap-NG project.

mutipg commented 4 months ago

Maybe it would be possible to turn on a timer (e.g. in the form of a stopwatch) between edits in realtify and block the download of the relation for a user who has just sent one edit?

Sometimes I forget about the 3-minute rule and this creates unwanted duplicates.

Zaczero commented 4 months ago

I have added a conflict detection mechanism.

The issue should be now resolved :+1:. Sorry for keeping you waiting.

The message will look like: Conflict: Way XXXXX was modified. Go back and click the relation reload button.

mutipg commented 1 month ago

The problem still persists. Yesterday, two editions of a similar bus route with an interval of 3 minutes generated duplicate sections of the way.

Zaczero commented 1 month ago

I will take a closer look at it, thanks for letting me know and sorry for the issue!

Additional info:

mutipg commented 1 week ago

Maybe it would be worth starting some kind of timer before the next edition in Relatify. Many people probably already use this application and do not wait for the data to be updated on the Overpass server, creating duplicate lines.

Here is another such situation. https://www.openstreetmap.org/changeset/157830755