Open Dimitar5555 opened 1 year ago
This occurred because two edits were performed in very quick succession, which didn't allow Overpass a chance to synchronize. I believe this issue could be resolved by temporarily storing recent splits in memory and preventing the user from loading a new relation when the database hasn't been fully synchronized. Alternatively, an even more advanced merge logic could be implemented to detect and resolve situations like this.
https://www.openstreetmap.org/changeset/139108512 https://www.openstreetmap.org/changeset/139108622
Thank you for reporting the bug!
Through the following MapRoulette challenge, I came across a lot of these errors, mostly by myself and created by Relatify. https://maproulette.org/browse/challenges/39506
Here the initial changeset: https://www.openstreetmap.org/changeset/139253149 Here the fixing changeset: https://www.openstreetmap.org/changeset/141252802
I have seen several instances of this bug in my neighbourhood recently, introduced by another contributor using osm-relatify.
The problem can be described like this:
This is creating a mess in OSM and requires time to clean up, can you at least workaround the problem so that people don't trigger this bug? Like forcing a delay between edits?
Here is an example of duplicated ways exhibiting the issues that I haven't yet fixed:
This still happens on a lot of places. Is there any workaround to stop this happening? Hard reload the browser? How much time should I wait between edits?
How much time should I wait between edits?
upload -> 3 minutes -> load
This issue will be resolved with OpenStreetMap-NG project.
Maybe it would be possible to turn on a timer (e.g. in the form of a stopwatch) between edits in realtify and block the download of the relation for a user who has just sent one edit?
Sometimes I forget about the 3-minute rule and this creates unwanted duplicates.
I have added a conflict detection mechanism.
The issue should be now resolved :+1:. Sorry for keeping you waiting.
The message will look like: Conflict: Way XXXXX was modified. Go back and click the relation reload button.
The problem still persists. Yesterday, two editions of a similar bus route with an interval of 3 minutes generated duplicate sections of the way.
I will take a closer look at it, thanks for letting me know and sorry for the issue!
Additional info:
Maybe it would be worth starting some kind of timer before the next edition in Relatify. Many people probably already use this application and do not wait for the data to be updated on the Overpass server, creating duplicate lines.
Here is another such situation. https://www.openstreetmap.org/changeset/157830755
I'm not sure how or why it might've happened, but the roundabout is somehow duplicated. On the west side it is quite segmented.
All other segments are duplicated normally (from one exit/entrance to the next).
The duplicate was introduced in https://www.osm.org/changeset/139108622 and I've removed it manually in https://www.osm.org/changeset/139125857.