search

Zaczero / osm-revert

⏪ OpenStreetMap Changeset Reverter — CLI + Website
https://revert.monicz.dev
GNU Affero General Public License v3.0
64 stars 6 forks source link

RATE_LIMITED on "Discussing changesets" #32

Open yrtimiD opened 4 months ago

yrtimiD commented 4 months ago

After reverting around 50 changesets within a few minutes with "Auto-discussion" enabled, some discussion comment adding fails with RATE_LIMITED.

Zaczero commented 4 months ago

Hey! How would you want such situations to be handled? Currently it just skips over the failed discussions.

yrtimiD commented 4 months ago

Right, challenging situation. First thing I thought about is at least allowing manual retry action. User might need to wait some time before using the retry option. Also, if api response has a clue about lockout period - will be very nice to show it.

Zaczero commented 4 months ago

With how osm-revert is designed, a manual retry action is not trivial to do. Ideally, osm-revert would parse OSM response headers to understand current rate limits and adjust its operation. However, I couldn't find any public documentation on this. The good news is that OpenStreetMap-NG already supports rate limit headers, so at some point, this issue will be resolved.

yrtimiD commented 4 months ago

I see. Maybe at least we can linkify changets numbers in the log to make manual discussion adding slightly less painful?

Zaczero commented 4 months ago

Okay sounds really useful! I have created an issue but I cannot give any ETA on the completion date.