Zagrios / bs-manager

An all-in-one tool that lets you easly manage BeatSaber versions, maps, mods, and even more.
GNU General Public License v3.0
509 stars 39 forks source link

[BUG] : Cannot install new versions #510

Closed Insprill closed 1 month ago

Insprill commented 1 month ago

Bug Description

When trying to install a new version, after selecting the platform (in my case, Steam), the popup closes and it silently fails with the following error:

15:18:15.719 › initVersionMetadata error Error: ENOENT: no such file or directory, open '/home/insprill/Documents/BSManager/BSInstances/1.37.0/metadata.config'

1.37.0 is the version I was trying to install. As such, there's no instance folder for it.

Reproduction Steps

  1. Try to install a new version via Steam.

System Specs

OS: Arch Linux Version: ca722b2a1835685c0d69187a3ba3e266d1359464

Zagrios commented 1 month ago

@Insprill I was able to reproduce once, then nothing, do you still have the issue ?

Insprill commented 1 month ago

Yes, the issue is still present for me. I haven't tested on Windows, only on Linux.

Zagrios commented 1 month ago

From what i see its a permission issue trying to execute the DepotDownloader file on linux 🤔 I will try to look at that this week 👌

silentrald commented 1 month ago

@Zagrios, got this to work by getting the new version of DepotDownloader 2.6.0 (linux-x64.zip file). Although the QR code doesn't display on the login modal, checking on why that is.

image

silentrald commented 1 month ago

@Zagrios @Insprill, seems that the DepotDownloader file that was uploaded to GitHub was corrupted. GitHub only allows 50 MB file size limit and the file is ~70MB, and when I pulled the repository, I only get ~20MB of the file.

Might either need to compress the file within the repo and extract it after its cloned, or just download the build from the original repo so that this repo would conserve space on the git repo. Although, I've created a custom build of DepotDownloader that has support on showing challenge url rather than the qr code in the terminal.

Already created the fix, but might need more time since this needs to be hooked with the custom DepotDownloader. The fix also address the issue I've added above.

Although the QR code doesn't display on the login modal, checking on why that is.

Zagrios commented 1 month ago

@silentrald It's a pretty easy fix. In fact, I have a build that totally works on my machine with Linux (see image 1). Capture d’écran du 2024-08-04 14-37-06

However, each time I push the file to the repo, Git modifies the file, and then it doesn't work anymore (see image 2). image Here, I have not change the file but it told me that the file has changed :thinking:

silentrald commented 1 month ago

@Zagrios

However, each time I push the file to the repo, Git modifies the file, and then it doesn't work anymore (see image 2). Here, I have not change the file but it told me that the file has changed 🤔

Might have something to do with line endings (LF and CRLF). You might need to run this so that you can push LF line endings.

git config --global core.autocrlf false

Though not sure if that's it tbh, but hopefully it is.


But just updating the DepotDownloader didn't work on my end since I got this where QR code just infinitely loading

image

So not sure if the bug fix I created might be still needed in any case. Tell me if you need me to PR it so you can test it as well.

Zagrios commented 1 month ago

@silentrald @Insprill The file was not recognize as a binary file that was the issue Can you confirm that it works now ? It work for me now, even after deleting and recloning the repo

silentrald commented 1 month ago

@Zagrios, can confirm on my end

Insprill commented 1 month ago

Working on my end as well :)

Zagrios commented 1 month ago

Nice 🙌