Closed silentrald closed 1 month ago
Custom version name breaks installing BSIPA mod in linux. Eg. version name is 1.29.1 (Test)
1.29.1 (Test)
1] 21:30:07.182 › START IPA PROCESS screen -dmS "BSIPA" dotnet /home/<username>/BSManager/BSInstances/1.29.1 (Test 1)/IPA.exe -n [1] 21:30:07.198 › IPA process stderr /bin/sh: -c: line 1: syntax error near unexpected token `(' [1] /bin/sh: -c: line 1: `screen -dmS "BSIPA" dotnet /home/<username>/BSManager/BSInstances/1.29.1 (Test 1)/IPA.exe -n' [1] [1] 21:30:07.199 › Ipa process exist with non 0 code 2 [1] 21:30:07.199 › Error: Unable to install BSIPA [1] at BsModsManagerService.installMods (/home/<username>/Desktop/Beat_Saber/bs-manager/.erb/dll/main.bundle.dev.js:149365:66) [1] at process.processTicksAndRejections (node:internal/process/task_queues:95:5) cannot-install-bsipa
Requirements: Uninstall BSIPA on the version you are testing.
For reviewers: Emojis can be added to comments to call out blocking versus non-blocking feedback.
E.g: Praise, minor suggestions, or clarifying questions that don’t block merging the PR.
🟢 Nice refactor! 🟡 Why was the default value removed?
🟢 Nice refactor!
🟡 Why was the default value removed?
E.g: Blocking feedback must be addressed before merging.
🔴 This change will break something important
Issues 0 New issues 0 Accepted issues
Measures 0 Security Hotspots 0.0% Coverage on New Code 0.0% Duplication on New Code
See analysis details on SonarCloud
Scope
Custom version name breaks installing BSIPA mod in linux. Eg. version name is
1.29.1 (Test)
How to Test
Requirements: Uninstall BSIPA on the version you are testing.
1.29.1 (Test)
.Emoji Guide
For reviewers: Emojis can be added to comments to call out blocking versus non-blocking feedback.
E.g: Praise, minor suggestions, or clarifying questions that don’t block merging the PR.
E.g: Blocking feedback must be addressed before merging.