Zahariel1942 / D2Stats

15 stars 7 forks source link

Notifier refactor, toggle show items and more #9

Closed synonymouse closed 7 months ago

synonymouse commented 7 months ago

Hello, initially I only wanted to add the ability to interact with objects during 'show items'. But then things escalated, and I ended up formatting the stats neatly in a column and eventually completely refactored the notifier. This was my first time working with AutoIt and the game's memory, so it turned out the way it did. Here is almost the complete list of changes:

I strongly recommend rewriting your loot filters in a slightly different style. All changes were made with the idea that you first hide large pools of items, and then gradually reveal them as needed. Read the help section in the notifier. I have added a few examples there. Also, created a 'Default' list of rules and use it as a starting point.

Let me know if you have any comments about the code and functionality, we will discuss them if needed and will make the necessary corrections. If everything is okay, please merge and deploy the new version. After that, I'll create a forum post with the new version and the text I wrote above.

synonymouse commented 7 months ago

For a general understanding of the new version of the notifier. In the old version, when an item dropped, we compared it with each rule in the notifier. If there was a match by type, the loop stopped and an action occurred in accordance with the flags in the rule. Now, the loop does not stop, and in the case of a match, the item is added to a separate pool of items. After that, this pool goes through several filters and gradually narrows down through a series of other loops and checks according to certain criteria, until only one item remains in the pool.

Zahariel1942 commented 7 months ago

🥳This is a significant milestone, you're awesome! Perhaps we should increase the major version to 4?

Zahariel1942 commented 7 months ago

We can continue the updates on the 'next' branch.

synonymouse commented 7 months ago

🥳This is a significant milestone, you're awesome! Perhaps we should increase the major version to 4?

Thanks) Yes, I think there are enough features for a major version