Zaicon / InfiniteChestsV3

11 stars 16 forks source link

Limited Functionality for Guests #1

Open Zaicon opened 7 years ago

Zaicon commented 7 years ago

At the moment, guest access isn't handled very well. They only have basic functionality in that they can add and remove items to chests (if applicable). However, all guests share refill data (if one person takes something out of a 5-second refill chest, all guests have to wait 5 seconds for the refill to take effect). The plugin will also error or crash if a guest is given permission to do other things such as claim chests or use any other /chest commands.

Possible solutions to this are 1) add code in to handle guests separately (probably by index for refill chests and adding applicable handling code to other /chest commands), 2) change the storage key for chests from user ID to some other user-specific identification (username?) (but not index because we want this to persist between sessions, if possible), and 3) revert back to handling refills based on the chest instead of player (that is, if someone triggers a refill chest, all players have to wait for the refill instead of just that one player).

If anyone would like to comment on this or try implementing one of these, feel free to do so.

BubbaSWalter commented 4 years ago

The One thing I would like to see concerning guests is if the chest is protected they should not be able to open the chest. COncerning your question I like option 2