search

Zaicon / InfiniteChestsV3

11 stars 16 forks source link

Fixes #6, fixes #10, and fixes #11 #12

Closed mpql closed 2 years ago

mpql commented 4 years ago

This commit fixes bugs #6, #10, and #11, also fixes a warning on InfMain.cs#L640, updates AssemblyInfo.cs to version 1.3.0.0, and has my built files in Releases. I would recommend taking the bin directory out altogether, and submitting any binaries under the repository's Releases section, but I didn't take those files out in this commit.

I built this against the TerrariaServer.exe that comes with TShock 4.4.0 Pre-release 10 for Terraria 1.4.0.4.

Ran everything and tested it, all works fine on the above-mentioned version.

One note is that I made mimics spawned with a key of night outside the corruption or crimson spawn one of the two types randomly; I figure this made for easier access to items not normally found in your world evil's class of mimic.

It would also be reasonable to instead summon the corresponding mimic based on whether the world has corruption or crimson in it, but I don't know how to query that value, and TShock doesn't seem to have up-to-date (or even complete) documentation.

I couldn't seem to get it to not give you back the chest, WorldGen.KillTile seems to ignore setting noItem: true; I don't know why.

If you need me to change anything before accepting, let me know.

mpql commented 4 years ago

Also, apologies, I accidentally committed an AssemblyVersion.cs that had own my semver version tag on it for the .dll I compiled myself. This is not in the pull request, but that is why each issue has two references from me.

Illuminousity commented 4 years ago

You can use WorldGen.crimson to find out whether a world is crimson or not, if true then it is crimson, if false then the world is corruption! hope this helps!

mpql commented 4 years ago

I'm happy with the current behavior, but if I get around to playing more Terraria, I might edit this with an option to choose which behavior you want. :)