Zaid-Ajaj / DustyTables

Thin F# API for SqlClient for easy data access to ms sql server with functional seasoning on top
MIT License
74 stars 11 forks source link

Add `Sql.dateTimeOffset` and `dateTimeOffsetOrNone` #13

Closed JaggerJo closed 4 years ago

JaggerJo commented 4 years ago

Proposed Changes

Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature request, be sure to link to that issue.

Types of changes

What types of changes does your code introduce to DustyTables? Put an x in the boxes that apply

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

Zaid-Ajaj commented 4 years ago

Do you still want to add the TimeSpan stuff or should I just merge this in? :wink:

JaggerJo commented 4 years ago

Do you still want to add the TimeSpan stuff or should I just merge this in? 😉

No, storing timespans as bigints should be fine IMHO.

Zaid-Ajaj commented 4 years ago

@JaggerJo Merged and published as of v2.3.0 🚀 thanks a lot