search

Zaid-Ajaj / Fable.Remoting

Type-safe communication layer (RPC-style) for F# featuring Fable and .NET Apps
https://zaid-ajaj.github.io/Fable.Remoting/
MIT License
272 stars 54 forks source link

Remove redundant target frameworks #176

Closed kerams closed 4 years ago

kerams commented 4 years ago

Targetting net462 on top of net45 is unnecessary because the latter can be used in any application compiled against .NET 4.5 through 4.8. Targetting netcoreapp3.1 on top of netstandard2.0 is unnecessary for the same reason on .NET Core as well as the fact that they don't have a different set of dependencies either (like this where netcoreapp3.0 drops obsolete ASP.NET packages, symplifying dependency graphs and lock files in .NET Core 3.0+ applications). The only exception here is the MsgPack project, which conditionally relies on specific .NET Core APIs.

The result of this change are slightly faster builds and slightly smaller Nuget packages.

kerams commented 4 years ago

Also maybe gitignore ionide cache? :)

Zaid-Ajaj commented 4 years ago

I don't know for sure if we should drop netcoreapp3.1 because I think (and I am not sure) that it is sometimes needed when using the library in azure functions. I can't find the issue but it was something like that

Zaid-Ajaj commented 4 years ago

I guess we will hear about if it really an issue :wink: let's get this in for now